Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursion issues with paper-input inside paper-submenu (polymer 1.2.4) #324

Open
tbone587 opened this issue Feb 2, 2016 · 4 comments
Open

Recursion issues with paper-input inside paper-submenu (polymer 1.2.4) #324

tbone587 opened this issue Feb 2, 2016 · 4 comments
Labels
p0 - critical

Comments

@tbone587
Copy link

tbone587 commented Feb 2, 2016

Ever since upgrading to polymer 1.2.4 the paper-inputs throw recursions error in google chrome and firefox when inside a paper-submenu. It seems like the paper-item menu trigger causes the problem. If that is swapped out to a div, everything works as expected..
@notwaldorf
Copy link
Contributor

I don't think I can actually reproduce this. Here's a jsbin with what I've got: http://jsbin.com/bamoge/edit?html,console,output, which works fine. and throws no errors.

Could you please clone that jsbin and show me your repro steps?

@tbone587
Copy link
Author

tbone587 commented Feb 2, 2016

Your jsbin generates the error for me after clicking around in the menus. I did update all, which I will never do again. I got into the habit of doing a bower update, and never really had a bower.json setup properly. This update has royally set me back and is a huge bug.

@notwaldorf
Copy link
Contributor

Ah, I see the errors now too, sorry about that. I think this is happening because of the focus events bubbling: paper-submenu is focused, which focuses its paper-input, which focuses its nested input, which triggers a focus event that the paper-submenu catches.

If you want to not use this release of paper-input, you can just use "paper-input": "PolymerElements/paper-input#^1.2.3" in your bower.json

@notwaldorf notwaldorf mentioned this issue Feb 9, 2016
Closed
@FLamparski
Copy link

This issue also occurs when using a paper-icon-button as suffix. The bug must have been re-introduced after v1.1.0.

FLamparski added a commit to FLamparski/paper-combo-date-input that referenced this issue May 9, 2016
@FLamparski
Initial commit; forces paper-input@1.1.0 due to PolymerElements/paper…
2a4c41a 
…-input#324
@Zecat Zecat mentioned this issue Jun 26, 2017
Closed
jhuesos added a commit to ellipticaljs/paper-autocomplete that referenced this issue Jul 15, 2017
@jhuesos
Making clear button non focusable. This is a temporary workaround until
09e7c15 
PolymerElements/paper-input#324 is fixed
jhuesos added a commit to ellipticaljs/paper-autocomplete that referenced this issue Jul 16, 2017
@jhuesos
## Release 3.0.0 (2017-07-16)
21f27a7 
### Breaking Changes
- This version does not contain any breaking change in the API. The breaking changes come from limitations in styling
when working with `<slots>` and ``::slotted()``. Due to this limitations, when working with custom templates, you must
put your `<style>` inside the custom template `<template>` tag.

### New Features
- The component has been transformed to work in *hybrid mode*, which means that the component is now compatible with
both Polymer 1.x and Polymer 2.x.

*Special thanks to everyone who has contributed to this version. Specially *@ajbarriosleon, @kamte* who did most of
heavy-lifting at the beginning of this new version.

### Known Issues
- `tabindex="-1"` was added to the clear button, so you can no longer use tab to focus it.
This is a temporary workaround until this issue is fixed: PolymerElements/paper-input#324 .
@khammami khammami mentioned this issue May 8, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p0 - critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@FLamparski @notwaldorf @tbone587