-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
styles not applied to slotted input in 2.x #639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
paper-input.html
Outdated
@apply --paper-input-container-input; | ||
} | ||
|
||
input::-webkit-outer-spin-button, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a duplicate, same rules applied few lines below
@@ -89,27 +89,17 @@ | |||
} | |||
|
|||
input { | |||
position: relative; /* to make a stacking context */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 for removing this block & reusing the mixin!
Fixes #638, #636, #613.
It's hard to add a test for this, so I've added a super complex
demo-snippet
: