Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showText() #50

Closed
wants to merge 2 commits into from
Closed

showText() #50

wants to merge 2 commits into from

Conversation

redbassett
Copy link
Contributor

Add a method to both set the toast's text and fire its show() method in one step.

This allows the following to be combined into one line:

myToast.text = "Hello World!";
myToast.show();
myToast.showText("Hello World!");

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@redbassett
Copy link
Contributor Author

I signed it

@googlebot
Copy link

CLAs look good, thanks!

@cdata
Copy link
Contributor

cdata commented Dec 16, 2015

Hey, thanks for the contribution. Our contributor guidelines ask that you open an issue to discuss design before offering an implementation. You can read more about that here: https://github.com/PolymerElements/paper-toast/blob/master/CONTRIBUTING.md

I'm going to close this for now pending further discussion of the design in an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants