New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #54 #63
Fix #54 #63
Conversation
@@ -87,6 +87,7 @@ | |||
`--paper-toolbar` | Mixin applied to the toolbar | `{}` | |||
`--paper-toolbar-medium` | Mixin applied to medium height toolbar | `{}` | |||
`--paper-toolbar-tall` | Mixin applied to tall height toolbar | `{}` | |||
`--paper-toolbar-transition` | Transition applied to the `.animate` class | `height 0.18s ease-in` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is something else expected to add this class? If not, this might be a good time to document it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Friendly ping @blasten 🍰
ping |
…olbar into transition-prop
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
@bicknellr @addyosmani There you go.! |
@@ -100,7 +104,7 @@ | |||
<dom-module id="paper-toolbar"> | |||
<template> | |||
<style> | |||
:host { | |||
:host {` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stray ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O.o Fixed! @bicknellr
aa1a327
to
e107f84
Compare
CLAs look good, thanks! |
LGTM |
Fixes #54