Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #54 #63

Merged
merged 3 commits into from Jan 27, 2016
Merged

Fix #54 #63

merged 3 commits into from Jan 27, 2016

Conversation

blasten
Copy link
Contributor

@blasten blasten commented Nov 25, 2015

Fixes #54

@@ -87,6 +87,7 @@
`--paper-toolbar` | Mixin applied to the toolbar | `{}`
`--paper-toolbar-medium` | Mixin applied to medium height toolbar | `{}`
`--paper-toolbar-tall` | Mixin applied to tall height toolbar | `{}`
`--paper-toolbar-transition` | Transition applied to the `.animate` class | `height 0.18s ease-in`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is something else expected to add this class? If not, this might be a good time to document it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friendly ping @blasten 🍰

@bicknellr
Copy link
Contributor

ping

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@blasten
Copy link
Contributor Author

blasten commented Jan 27, 2016

@bicknellr @addyosmani There you go.!

@@ -100,7 +104,7 @@
<dom-module id="paper-toolbar">
<template>
<style>
:host {
:host {`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray ```

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O.o Fixed! @bicknellr

@googlebot
Copy link

CLAs look good, thanks!

@bicknellr
Copy link
Contributor

LGTM

blasten added a commit that referenced this pull request Jan 27, 2016
@blasten blasten merged commit ebc0605 into master Jan 27, 2016
@blasten blasten deleted the transition-prop branch January 27, 2016 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants