-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NFT transfer events #1427
Merged
Merged
Add NFT transfer events #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1427 +/- ##
===========================================
+ Coverage 53.68% 53.82% +0.13%
===========================================
Files 149 149
Lines 32486 32443 -43
===========================================
+ Hits 17439 17461 +22
+ Misses 15047 14982 -65
|
HenriqueNogara
commented
Apr 3, 2023
Neopallium
approved these changes
May 2, 2023
… AssetBalanceUpdated event; Remove old move_funds extrinsic
HenriqueNogara
force-pushed
the
MESH-1991/add-nft-transfer-event
branch
from
May 24, 2023 19:20
cab945a
to
804e4f0
Compare
…d both PortfolioId as optional
adamdossa
approved these changes
Jun 1, 2023
Neopallium
requested changes
Jun 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor point about the caller_did in the events.
HenriqueNogara
force-pushed
the
MESH-1991/add-nft-transfer-event
branch
from
June 5, 2023 18:37
9bb387b
to
1105d14
Compare
HenriqueNogara
commented
Jun 5, 2023
Neopallium
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
AssetBalanceUpdated
,NFTCountUpdated
andFundsMovedBetweenPortfolios
events.changelog
modified API
asset_pallet
:Transfer
,Issued
andRedeemed
;asset_pallet
:AssetBalanceUpdated
;nft_pallet
:IssuedNFT
,RedeemedNFT
;nft_pallet
:NFTPortfolioUpdated
;portfolio_pallet
:MovedBetweenPortfolios
,NFTsMovedBetweenPortfolios
andFungibleTokensMovedBetweenPortfolios
;portfolio_pallet
:FundsMovedBetweenPortfolios
;move_portfolio_funds_v2
;move_portfolio_funds
have changed.