Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NFT transfer events #1427

Merged
merged 6 commits into from
Jun 6, 2023
Merged

Conversation

HenriqueNogara
Copy link
Contributor

@HenriqueNogara HenriqueNogara commented Apr 3, 2023

Adds the AssetBalanceUpdated, NFTCountUpdated and FundsMovedBetweenPortfolios events.

changelog

modified API

  • The following events were removed from the asset_pallet: Transfer, Issued and Redeemed;
  • The following event was added to the asset_pallet: AssetBalanceUpdated;
  • The following events were removed from the nft_pallet: IssuedNFT, RedeemedNFT;
  • The following event was added to the nft_pallet: NFTPortfolioUpdated;
  • The following events were removed from the portfolio_pallet: MovedBetweenPortfolios, NFTsMovedBetweenPortfolios and FungibleTokensMovedBetweenPortfolios;
  • The following event was added to the portfolio_pallet: FundsMovedBetweenPortfolios;
  • The following extrisinc was deleted: move_portfolio_funds_v2;
  • The parameters for move_portfolio_funds have changed.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1427 (f72126f) into develop (cda949b) will increase coverage by 0.13%.
The diff coverage is 72.00%.

@@             Coverage Diff             @@
##           develop    #1427      +/-   ##
===========================================
+ Coverage    53.68%   53.82%   +0.13%     
===========================================
  Files          149      149              
  Lines        32486    32443      -43     
===========================================
+ Hits         17439    17461      +22     
+ Misses       15047    14982      -65     
Impacted Files Coverage Δ
pallets/common/src/traits/asset.rs 0.00% <0.00%> (ø)
pallets/common/src/traits/nft.rs 0.00% <0.00%> (ø)
pallets/common/src/traits/portfolio.rs 0.00% <0.00%> (ø)
pallets/weights/src/pallet_portfolio.rs 0.00% <0.00%> (ø)
primitives/src/lib.rs 79.78% <ø> (ø)
primitives/src/nft.rs 75.92% <ø> (ø)
primitives/src/portfolio.rs 33.33% <50.00%> (+33.33%) ⬆️
pallets/settlement/src/lib.rs 77.47% <94.44%> (+0.31%) ⬆️
pallets/asset/src/lib.rs 81.42% <100.00%> (+0.22%) ⬆️
pallets/corporate-actions/src/distribution/mod.rs 51.19% <100.00%> (+0.97%) ⬆️
... and 2 more

... and 2 files with indirect coverage changes

@adamdossa adamdossa changed the title Add NFT transfer events WIP: Add NFT transfer events May 2, 2023
… AssetBalanceUpdated event; Remove old move_funds extrinsic
@HenriqueNogara HenriqueNogara force-pushed the MESH-1991/add-nft-transfer-event branch from cab945a to 804e4f0 Compare May 24, 2023 19:20
@HenriqueNogara HenriqueNogara changed the title WIP: Add NFT transfer events Add NFT transfer events May 24, 2023
Copy link
Contributor

@Neopallium Neopallium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor point about the caller_did in the events.

pallets/nft/src/lib.rs Outdated Show resolved Hide resolved
pallets/asset/src/lib.rs Outdated Show resolved Hide resolved
pallets/portfolio/src/lib.rs Outdated Show resolved Hide resolved
@HenriqueNogara HenriqueNogara force-pushed the MESH-1991/add-nft-transfer-event branch from 9bb387b to 1105d14 Compare June 5, 2023 18:37
pallets/settlement/src/lib.rs Outdated Show resolved Hide resolved
pallets/settlement/src/lib.rs Outdated Show resolved Hide resolved
@HenriqueNogara HenriqueNogara merged commit a915992 into develop Jun 6, 2023
13 checks passed
@HenriqueNogara HenriqueNogara deleted the MESH-1991/add-nft-transfer-event branch June 6, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants