Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Polymesh to support Substrate monthly 2023-03 #1466

Merged
merged 6 commits into from
Jun 13, 2023

Conversation

Neopallium
Copy link
Contributor

@Neopallium Neopallium commented Jun 7, 2023

Substrate update (2023-03) for Polymesh v6 using branch polymesh-v6-monthly-2023-03.

changelog

new features

  • Update to Substrate monthly-2023-03 with trie-db fixes backported.
  • Substrate - HTTP/WS rpc on the same port. The old http-only port is still supported, the ws port now supports both.

modified API

  • Extrinsic ids in the System pallet have changed because fill_block has been removed.
  • Added transfer_no_cdd to the Currency trait in frame_support. To allow transferring POLYX to accounts without a CDD (i.e. Contract's deposit account).

modified logic

  • Substrate removed the uncles block support. Wasn't even working before.
  • Contract's now have a "deposit account" to hold their storage deposits.

data migration

  • Storage migration for pallet_scheduler was added. It just cleans up None values from the scheduled tasks lists, no type changes.

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #1466 (375c16f) into develop (2e717ff) will decrease coverage by 0.31%.
The diff coverage is 61.42%.

@@             Coverage Diff             @@
##           develop    #1466      +/-   ##
===========================================
- Coverage    54.06%   53.76%   -0.31%     
===========================================
  Files          149      149              
  Lines        32737    32909     +172     
===========================================
- Hits         17700    17692       -8     
- Misses       15037    15217     +180     
Impacted Files Coverage Δ
pallets/committee/src/lib.rs 77.20% <ø> (ø)
pallets/runtime/common/src/lib.rs 68.75% <ø> (ø)
pallets/runtime/common/src/runtime.rs 1.69% <0.00%> (ø)
pallets/runtime/develop/src/runtime.rs 3.63% <0.00%> (-0.03%) ⬇️
pallets/runtime/extensions/src/check_weight.rs 30.00% <0.00%> (ø)
pallets/weights/src/pallet_babe.rs 0.00% <0.00%> (ø)
src/service.rs 0.00% <0.00%> (ø)
primitives/src/calendar.rs 73.66% <93.93%> (-2.74%) ⬇️
pallets/balances/src/lib.rs 72.50% <100.00%> (+0.18%) ⬆️
pallets/staking/src/lib.rs 55.87% <100.00%> (-0.03%) ⬇️
... and 1 more

... and 12 files with indirect coverage changes

@Neopallium Neopallium changed the title [WIP] Update Polymesh to support Substrate monthly 2023-03 Update Polymesh to support Substrate monthly 2023-03 Jun 7, 2023
@Neopallium
Copy link
Contributor Author

Neopallium commented Jun 8, 2023

  • Check for Substrate migrations.
  • Review changes to Account reserve logic changes.
  • Review/update benchmark templates for PoV changes. We don't really need the PoV values.

@adamdossa adamdossa merged commit 45d81e5 into develop Jun 13, 2023
13 checks passed
@adamdossa adamdossa deleted the substrate-monthly-2023-03 branch June 13, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants