Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction fee paid fix #1479

Merged
merged 4 commits into from Jun 22, 2023
Merged

Transaction fee paid fix #1479

merged 4 commits into from Jun 22, 2023

Conversation

Neopallium
Copy link
Contributor

@Neopallium Neopallium commented Jun 22, 2023

changelog

modified logic

  • Use the paying account id in the TransactionFeePaid event, instead of the caller account.
  • Remove the 80/20 split between treasury/author. The block author gets 100% of transaction/protocol fees.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1479 (835db89) into develop (de418e9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1479      +/-   ##
===========================================
- Coverage    53.94%   53.93%   -0.01%     
===========================================
  Files          151      151              
  Lines        32890    32890              
===========================================
- Hits         17741    17740       -1     
- Misses       15149    15150       +1     
Impacted Files Coverage Δ
pallets/runtime/develop/src/runtime.rs 3.63% <ø> (ø)
pallets/transaction-payment/src/lib.rs 49.26% <100.00%> (ø)

... and 1 file with indirect coverage changes

@adamdossa adamdossa merged commit 1c53c22 into develop Jun 22, 2023
13 checks passed
@adamdossa adamdossa deleted the transaction_fee_paid_fix branch June 22, 2023 13:29
adamdossa pushed a commit that referenced this pull request Jun 26, 2023
* Fix payer in transaction fee paid event.

* 100% of transaction/protocol fees goto the block author.

* cleanup.

* cargo fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants