-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesh 1967 cleanup checkpoint schedules #1488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1488 +/- ##
===========================================
- Coverage 54.43% 54.21% -0.23%
===========================================
Files 151 151
Lines 32960 32988 +28
===========================================
- Hits 17942 17884 -58
- Misses 15018 15104 +86
|
Neopallium
changed the title
[WIP] Mesh 1967 cleanup checkpoint schedules
Mesh 1967 cleanup checkpoint schedules
Jun 30, 2023
Neopallium
requested review from
HenriqueNogara and
adamdossa
and removed request for
HenriqueNogara
June 30, 2023 13:32
adamdossa
approved these changes
Jul 3, 2023
HenriqueNogara
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog
new features
Moment
checkpoints, instead of complex calendar basic repeating values.modified API
Checkpoint.create_schedule
now take aScheduleCheckpoints
(holds aBTreeSet
ofMoment
values) instead ofScheduleSpec
.ScheduleCreated
andScheduleRemoved
changed to haveScheduleId
andScheduleCheckpoints
instead ofStoredSchedule
.Schedules
replaced with double mapScheduledCheckpoints
. Schedules are no longer stored in aVec
.CachedNextCheckpoints
is used to quickly check if aticker
has any checkpoints that need to be created.modified logic
Moment
) need to be calculated off-chain.data migration
Checkpoint.Schedules
are migrated to new structure, only a maximum of the next 10 checkpoints are kept for each schedule.