Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh 2090/add nft controller transfer #1529

Merged
merged 8 commits into from
Oct 17, 2023

Conversation

HenriqueNogara
Copy link
Contributor

@HenriqueNogara HenriqueNogara commented Sep 25, 2023

changelog

new features

  • Adds the controller_transfer extrinsic to pallet_nft;
  • Adds NFTsInCollection storage to track the number of nfts in a collection;

modified API

  • Adds the following variants to the nft error enum: SupplyOverflow, SupplyUnderflow;
  • Adds the following variant to PortfolioUpdateReason: ControllerTransfer;

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #1529 (5d80b40) into develop (1fd503a) will decrease coverage by 0.10%.
The diff coverage is 49.65%.

@@             Coverage Diff             @@
##           develop    #1529      +/-   ##
===========================================
- Coverage    58.65%   58.55%   -0.10%     
===========================================
  Files          142      142              
  Lines        31881    31992     +111     
===========================================
+ Hits         18699    18734      +35     
- Misses       13182    13258      +76     
Files Coverage Δ
pallets/asset/src/lib.rs 82.51% <100.00%> (ø)
pallets/common/src/traits/nft.rs 0.00% <ø> (ø)
primitives/src/portfolio.rs 33.33% <ø> (ø)
pallets/weights/src/pallet_nft.rs 0.00% <0.00%> (ø)
pallets/nft/src/lib.rs 57.11% <57.85%> (-8.80%) ⬇️

... and 2 files with indirect coverage changes

Neopallium

This comment was marked as resolved.

@adamdossa adamdossa merged commit 3ab8456 into develop Oct 17, 2023
14 checks passed
@adamdossa adamdossa deleted the MESH-2090/add-nft-controller-transfer branch October 17, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants