Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESH-2096/allow-sc-deploy-as-child-id #1548

Merged
merged 7 commits into from
Nov 9, 2023

Conversation

HenriqueNogara
Copy link
Contributor

@HenriqueNogara HenriqueNogara commented Oct 26, 2023

Allows a contract to be deployed as a primary key of a child identity.

changelog

new features

  • Adds the following extrisincs: instantiate_with_code_as_primary_key, instantiate_with_hash_as_primary_key;

modified logic

  • on_instantiate_transfer if contract_did is different from the caller's did, also check if its parent match the caller's identity;

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #1548 (05d0902) into develop (9734963) will decrease coverage by 0.03%.
The diff coverage is 57.57%.

@@             Coverage Diff             @@
##           develop    #1548      +/-   ##
===========================================
- Coverage    58.58%   58.55%   -0.03%     
===========================================
  Files          142      142              
  Lines        32104    32118      +14     
===========================================
  Hits         18807    18807              
- Misses       13297    13311      +14     
Files Coverage Δ
pallets/identity/src/keys.rs 86.73% <60.00%> (-0.50%) ⬇️
pallets/weights/src/polymesh_contracts.rs 28.98% <55.55%> (+3.98%) ⬆️

... and 5 files with indirect coverage changes

@HenriqueNogara HenriqueNogara changed the title WIP: MESH-2096/allow-sc-deploy-as-child-id MESH-2096/allow-sc-deploy-as-child-id Oct 27, 2023
Neopallium

This comment was marked as resolved.

@adamdossa adamdossa merged commit af8f1c3 into develop Nov 9, 2023
14 checks passed
@adamdossa adamdossa deleted the MESH-2096/allow-sc-deploy-as-child-id branch November 9, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants