Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow Identities to join MultiSigs as signers #1556

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

adamdossa
Copy link
Collaborator

changelog

modified API

  • accept_multisig_signer_as_identity will now always fail

modified logic

  • No longer permit Identity based multisig signers

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #1556 (76dc10d) into develop (af8f1c3) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1556      +/-   ##
===========================================
- Coverage    58.56%   58.55%   -0.02%     
===========================================
  Files          142      142              
  Lines        32118    32120       +2     
===========================================
- Hits         18811    18807       -4     
- Misses       13307    13313       +6     
Files Coverage Δ
pallets/multisig/src/lib.rs 85.33% <100.00%> (+0.03%) ⬆️

... and 3 files with indirect coverage changes

@Neopallium Neopallium merged commit 3e7743d into develop Nov 14, 2023
14 checks passed
@Neopallium Neopallium deleted the disallow_identity_multisig_signer_auths branch November 14, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants