Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port example contracts to Ink! 4.3 #1569

Merged
merged 13 commits into from
Dec 12, 2023
Merged

Port example contracts to Ink! 4.3 #1569

merged 13 commits into from
Dec 12, 2023

Conversation

Neopallium
Copy link
Contributor

@Neopallium Neopallium commented Nov 28, 2023 •
edited

changelog

new features

  • Update example contracts.
  • Add logging of Chain Extension errors for easier debugging.

@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited

Codecov Report

Merging #1569 (496e19b) into develop (c0c08f7) will increase coverage by 0.00%.
The diff coverage is 89.47%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1569   +/-   ##
========================================
  Coverage    58.66%   58.67%           
========================================
  Files          142      142           
  Lines        32236    32236           
========================================
+ Hits         18911    18913    +2     
+ Misses       13325    13323    -2
Files Coverage Δ
contracts/upgradeable-polymesh-ink/src/macros.rs 44.95% <89.47%> (ø)

... and 2 files with indirect coverage changes

@Neopallium Neopallium changed the title [WIP] Start porting example contracts to Ink! 4.3 Start porting example contracts to Ink! 4.3 Nov 28, 2023
@Neopallium Neopallium mentioned this pull request Nov 28, 2023
Closed
@Neopallium Neopallium changed the title Start porting example contracts to Ink! 4.3 Port example contracts to Ink! 4.3 Nov 29, 2023
Neopallium and others added 2 commits December 6, 2023 21:40
@Neopallium
Update contract's DID on initialize.
b4e0f58
@HenriqueNogara
Add new api calls (#1572)
496e19b 
* Add new api calls

* Reexport NFTs type; Return InstructionId from add_and_affirm_instruction

* Export NFTId
@Neopallium Neopallium merged commit 9214c27 into develop Dec 12, 2023
14 checks passed
@Neopallium Neopallium deleted the contracts_ink_4_x branch December 12, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenriqueNogara HenriqueNogara HenriqueNogara approved these changes

@adamdossa adamdossa Awaiting requested review from adamdossa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Neopallium @HenriqueNogara