Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rpc calls #1650

Merged
merged 11 commits into from
May 7, 2024
Merged

Add new rpc calls #1650

merged 11 commits into from
May 7, 2024

Conversation

HenriqueNogara
Copy link
Contributor

@HenriqueNogara HenriqueNogara commented Apr 16, 2024

changelog

new features

  • Adds the following rpc endpoints: get_transfer_report, get_execute_instruction_report, compliance_report;

modified external API

  • Deprecate the can_transfer_granular rpc endpoints;

new external API

  • Adds the following errors to the asset pallet: InvalidTransferInvalidReceiverCDD, InvalidTransferInvalidSenderCDD;
  • Adds the following errors to the nft pallet: InvalidNFTTransferSenderIdMatchesReceiverId, InvalidNFTTransferInvalidReceiverCDD, InvalidNFTTransferInvalidSenderCDD;
  • Adds the following rpc endpoints: get_transfer_report, get_execute_instruction_report, compliance_report;

other

  • Adds check for valid cdd when transferring an asset;

Copy link
Contributor

@Neopallium Neopallium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Result<(), Vec<DispatchError>> type might be difficult to work with on the client side.

pallets/asset/src/lib.rs Outdated Show resolved Hide resolved
pallets/nft/src/lib.rs Outdated Show resolved Hide resolved
pallets/nft/src/lib.rs Outdated Show resolved Hide resolved
pallets/runtime/common/src/runtime.rs Outdated Show resolved Hide resolved
pallets/runtime/common/src/runtime.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Neopallium Neopallium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just need the Runtime APIs defined in the polymesh_schema.json.

polymesh_schema.json Outdated Show resolved Hide resolved
@adamdossa adamdossa merged commit 9e5fa26 into develop May 7, 2024
13 checks passed
@adamdossa adamdossa deleted the MESH-2147/new-rpc branch May 7, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants