transfer_benefit: fix 'remaining' underflow #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
added
the
release-notes
fmiguelgarcia
approved these changes
Mar 26, 2021
maxsam4
approved these changes
Mar 30, 2021
Codecov Report
@@ Coverage Diff @@
## develop #975 +/- ##
===========================================
+ Coverage 66.32% 66.47% +0.15%
===========================================
Files 90 90
Lines 14707 14710 +3
===========================================
+ Hits 9754 9779 +25
+ Misses 4953 4931 -22
|
Centril
force-pushed
the
claim-underflow-fix
branch
from
5f9577d
to
5137fae
Compare
Merged
maxsam4
added a commit
that referenced
this pull request
Apr 7, 2021
* Fixed cargo.lock (#971) * MESH-1545/Improve STO code coverage (#963) * WIP * revert logic changes * fix timestamps * comments Co-authored-by: Mudit Gupta <guptamudit@ymail.com> * unset PortfolioCustodian if custodian is owner (#976) * transfer_benefit: fix 'remaining' underflow (#975) Co-authored-by: poly-auto-merge[bot] <65769705+poly-auto-merge[bot]@users.noreply.github.com> * Expose constants in metadata (#972) * Exposed constants in metadata * fixed test build Co-authored-by: poly-auto-merge[bot] <65769705+poly-auto-merge[bot]@users.noreply.github.com> * Minor GC related fixes (#973) * minor fixes * fixed tests * linting Co-authored-by: poly-auto-merge[bot] <65769705+poly-auto-merge[bot]@users.noreply.github.com> * MESH-1600, MESH-1601, MESH-1590, MESH-1591 (#974) * mesh-1601: test asset limits * mesh-1601: test portfolio limits * mesh-1601: test contracts limits * mesh-1601: test ballot limits * mesh-1601: test pips limits * mesh-1601: test sto limits * mesh-1601: test settlement limits * identity_test: some assert_err! -> assert_noop! * various assert_err! -> assert_noop! * mesh-1600: fix transactionality issues * mesh-1601: test identity limits * mesh-1591, mesh-1590: refactor tests * import fixes * benchmark fixes * mesh-1601: address review comments * mesh-1601: address review comments + refactor * fixed build warning * Fixed test build Co-authored-by: Mudit Gupta <guptamudit@ymail.com> * UT for `add_investor_uniqueness_claim_v2` (#970) * New `Identity::add_investor_uniqueness_claim_v2` This version uses the new PIUSv2 version from `confidential_identity`. * Bug fix & benchmark * ScopeId generated from `InvestorZKProofData`. * minor fixes * updated schema * CodeReview fixes * Fix error from last merge * Add UT for add_investor_uniqueness_claim_v2 * Remove some intermedite changes * Add `scope_id` verification * CodeReview: Naming fixes * Add `Claim::InvestorUniquenessV2` * Fix WASM error in benchmark * Remove `Scope` from `Claim::InvestorUniquenessV2` * Fix Schema * Add doc about new `revoke_claim_by_index` * CodeReview: doc fixed Co-authored-by: Mudit Gupta <guptamudit@ymail.com> * Remove some unused RPCs (#980) * added rpc check * removed some unused RPCs * removed unused function * Update scripts/cli/util/rpc_u128_check.js Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> * Merge pull request #983 from PolymathNetwork/bump-versions Bumped version to 3.0.1 Co-authored-by: CJP10 <cjpet10@gmail.com> Co-authored-by: Vladimir Komendantskiy <komendantsky@gmail.com> Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Co-authored-by: poly-auto-merge[bot] <65769705+poly-auto-merge[bot]@users.noreply.github.com> Co-authored-by: Francisco Miguel García <fmiguelgarcia@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog
modified logic
Distribution::{claim, push_benefit}whereremainingcould underflow/wrap when sufficient tokens were locked butamountwas too small.