Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 馃幐 Export public entities, utils and consts #24

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

prashantasdeveloper
Copy link

Description

After the refactoring, all the entities and types were missing when PP SDK was included as a dependency in another project. This PR exports all the entities, constants and types which were present in public SDK, to resolve the issue.

Breaking Changes

NA

JIRA Link

DA-1151

Checklist

  • Updated the Readme.md (if required) ?

@prashantasdeveloper prashantasdeveloper requested a review from a team as a code owner April 23, 2024 10:35
@prashantasdeveloper
Copy link
Author

Once the public SDK has a version released by merging PolymeshAssociation#1205, this PR needs to update the SDK version

Copy link
Collaborator

@polymath-eric polymath-eric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, not sure if we need to reexport the public identity. If there is a reason to do so its OK to leave in

src/api/entities/Identity/index.ts Outdated Show resolved Hide resolved
src/api/entities/types.ts Show resolved Hide resolved
Copy link

sonarcloud bot commented Apr 25, 2024

@polymath-eric polymath-eric merged commit 2c6aa0b into master Apr 26, 2024
9 checks passed
@polymath-eric polymath-eric deleted the feat/extend-public-sdk branch April 26, 2024 15:47
@polymath-eric
Copy link
Collaborator

馃帀 This PR is included in version 1.1.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants