Rewrite towards hooks #336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #333 (eventually)
Motivation
The original motivation is that this lib was throwing deprecation warnings about
findDOMNodeinStrictModeon our project. Otherwise, though, it's about updating/modernizing the lib.Changes
See commit messages for a summary. I'm also happy to answer questions through a review, or annotate on my own through a review if you like.
Testing
I got stuck on rewriting the tests. I'm not super familiar with how Karma works - the only test framework I have any real experience with is mocha/enzyme. I got stuck on trying to
console.logthings to debug - I couldn't figure out where the output would show up, if it showed up at all.Any tips on testing and debugging?
Beyond that, I see the appeal in using browser-based tests for a lib that's built around browser interactions and browser quirks, but I've generally found that browser-based testing is a pain because it's hard to trace an error or failure back to its source. Do you have thoughts on moving towards something like
react-test-rendererthat's a bit friendlier to devs for most of the tests?