Make karma can run in a github action #370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you know why this needs Xvfb though? I like it, I'll be merging this in, but I want to understand why change was necessary (because I know the firefox folks, and needing to run things for its test bench is waaay more complex than most projects will ever need) |
|
Would have been nice to get an answer rather than a closed PR though =( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making karma can run in a GitHub action
refer to the https://github.com/karma-runner/karma-firefox-launcher/blob/master/.github/workflows/ci.yml
success example job: https://github.com/sinchang-codespaces/react-onclickoutside/actions/runs/1371324713
Closes #358