Add rename support for MySQL versions below 5.7 (and MariaDB) #321
Conversation
internal protects as well as private but now we can use the ctor from the unit-tests
Required a small change in the get SqlGenerator where a faked IMySqlOptions is injected with the correct MySQL version.
Right now it only overrides the Rename Index test to test that the generator creates proper statements
Using the ServerVersion flag SupportsRenameIndex.
I'll see what I can do about that |
|
Thanks for the PR! The MySQL 5.6 test is especially nice! |
|
Fantastic :) I was poking around in the I'll create a version of this for 1.1 as well. |
|
|
||
| builder.Append("ALTER TABLE ") | ||
| .Append(Dependencies.SqlGenerationHelper.DelimitIdentifier(operation.Table, operation.Schema)) | ||
| .Append(" CREATE INDEX ") |
There was a problem hiding this comment.
I just realized this won't work; it doesn't define any column names. I'm re-working this function so that it can detect UNIQUE, BTREE, etc. using the SHOW CREATE TABLE logic anyways though.
There was a problem hiding this comment.
Oh, yeah, you're completely right, my bad. Disregard #322 then.
This PR adds support for renaming indices on MySQL versions below 5.7 and MariaDB
ServerVersionupdated to determine whether renaming is supportedMySqlMigrationsSqlGeneratorupdated to supportRENAMEandDROP+CREATEone caveat if the index being renamed is unique and it is not version 5.7 I can't se a way to determine whether the index being changed is unique or not, hence it will DROP and create a non unique index.
Relates to #320