Require higher version of maturin #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisch
force-pushed
the
fix/maturin-version
branch
from
13c94b7
to
4c00463
Compare
Haaroon
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Requiring a higher version of maturin
Why are the changes needed?
Maturin's current highest version is 1.4.0, which is what I have tested with the python build. While I'm sure the very latest version of Maturin is required, I've tried installing with the currently listed version (0.13), and that did not seem to work as it was too old.
Does this PR introduce any user-facing change? If yes is this documented?
No
How was this patch tested?
Tested with Maturin 1.4.0 (for the proposed change) and 0.13 (for the current version).
Issues
N/A
Are there any further changes required?
No