_escape() in funs.py makes it impossible to match end of line?

[alix-tz]

I need to investigate this more to see if this is really the problem, but it seems that the static method _escape() in funcs.py causes a pattern such as #r#-$ to look for the literal string -$ instead of -<end-of-line>.

I am wondering what were the motivations of _escape(), and if we can have an alternative approach to be able to fully use regex' syntax.

[PonteIneptique]

(For ease of discussion, it's always good to link to functions by copying the uri for the given line. Press "Y" for the permanent commit identified URI, and select the line)

choco-mufin/chocomufin/funcs.py

Lines 119 to 131 in b1c009c

	@staticmethod
	def _escape(string: str):
	""" Escapes or not a string that is present in the control table. Strings starting with #r# are not escaped
	>>> Translator._escape("#r#(a|b)")
	'(a|b)'
	>>> Translator._escape("(a|b)") == r'\(a\|b\)'
	True
	"""
	if string.startswith("#r#"):
	return string[3:]
	return re.escape(string)

[PonteIneptique]

Given the function, #r#\w$ should not be escaped. You sure about this ?

[alix-tz]

Ah my bad, I read too quickly!
Then I'll keep "dérouler la pelote" to understand where the problem is.

[PonteIneptique]

I'd check if $ in parenthesis does not malfunction

https://github.com/PonteIneptique/choco-mufin/blob/b1c009cde3d2969080045ca93d77d0447ffdbe9d/chocomufin/funcs.py#L58C9-L58C118