Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.0 #304

Merged
merged 1 commit into from
May 20, 2021
Merged

v5.0.0 #304

merged 1 commit into from
May 20, 2021

Conversation

Rmannn
Copy link
Member

@Rmannn Rmannn commented Apr 13, 2021

BREAKING CHANGE

  • Signature of @Console decorator has been updated.
    ConsoleOptions has been replaced by CreateCommandOptions, to update from ^4.0.0 you simply have to change property name by command.
    eg: @Console({name: "myCommand"}) => @Console({command: "myCommand"})
  • Commander@< 7.2.0 is not any more supported. Please upgrade to latest version npm install commander@latest or using yarn yarn add commander@latest
  • The helper formatResponse has been removed

Changed

  • Update tests
  • Remove calls to command.exitOverride() to simplify code
  • Native errors handling with commander
  • update docs
  • update dependencies
  • Update to work with commander@7.2.0

Added

  • All commands and sub commands are stored in the ConsoleService and can be found using the ConsoleService.getCommand(name: string). Name is a command path separated by dots. eg: parent.command.subcommand
  • Sub commands can now be registered on other subCommand without any args. If a parent command define options, they can be retrieved using command.parent.opts() inside the executed subCommand. This allow you to create group of command with global options based on parent options

Fixed

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #304 (8a75932) into master (5ff85f4) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 8a75932 differs from pull request most recent head 1ceeef7. Consider uploading reports for the commit 1ceeef7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master      #304   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          178       182    +4     
  Branches        31        29    -2     
=========================================
+ Hits           178       182    +4     
Impacted Files Coverage Δ
src/bootstrap/console.ts 100.00% <ø> (ø)
src/constants.ts 100.00% <ø> (ø)
src/helpers.ts 100.00% <ø> (ø)
src/bootstrap/abstract.ts 100.00% <100.00%> (ø)
src/decorators.ts 100.00% <100.00%> (ø)
src/module.ts 100.00% <100.00%> (ø)
src/scanner.ts 100.00% <100.00%> (ø)
src/service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ff85f4...1ceeef7. Read the comment docs.

@Rmannn Rmannn changed the title Update to commander 7.2.0 v5.0.0 Apr 13, 2021
@Rmannn
Copy link
Member Author

Rmannn commented Apr 13, 2021

Add tests for @Console decorator new property options.

@Rmannn Rmannn merged commit 937e2c6 into master May 20, 2021
@Rmannn Rmannn deleted the feature/commander_7 branch July 16, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update commander peerdependencies version
1 participant