barcode_finder initial #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muriloformiga
requested review from
aquilarafa,
isadoraLima21,
a user,
joaopedroquintino,
kaiquegazola,
ThiagoFontes and
wesleybrunopop
| LuminanceSource source = new RGBLuminanceSource(bMap.getWidth(), bMap.getHeight(), intArray); | ||
| BinaryBitmap bitmap = new BinaryBitmap(new HybridBinarizer(source)); | ||
| try { | ||
| //Vector<BarcodeFormat> barcodeFormats = new Vector<>(); |
There was a problem hiding this comment.
Algum motivo para deixar esses comentários?
ThiagoFontes
suggested changes
Dec 21, 2020
Comment on lines
+3
to
+5
| public enum BarcodeType { | ||
| BARCODE, QRCODE | ||
| } |
There was a problem hiding this comment.
Essa nomenclatura está confusa, um QR code não é um tipo de código de barras, por que não utilizar os nomes dos formatos aceitos pela biblioteca usada?
| return null; | ||
| } | ||
|
|
||
| private String scanQRImage(Bitmap bMap, Reader reader) { |
There was a problem hiding this comment.
Parece que você está lendo todos os tipos possíveis com esta função, mas ela se chama scanQRImage, outro ponto é se não é feito um filtro com os tipos por que definir tipos diferentes? E isso não poderia acarretar em falsos positivos ao escanear um arquivo especifico com objetivo de apenas um dos itens?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.