Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

325 - ETL for loading custom layout #1

Merged
merged 15 commits into from Oct 22, 2018
Merged

325 - ETL for loading custom layout #1

merged 15 commits into from Oct 22, 2018

Conversation

amiedes
Copy link
Contributor

@amiedes amiedes commented Oct 18, 2018

No description provided.

@amiedes amiedes added the wip label Oct 18, 2018
@amiedes amiedes removed the wip label Oct 19, 2018
@amiedes
Copy link
Contributor Author

amiedes commented Oct 19, 2018

This is working OK and can be reviewed. There are some minor style adjustments pending in http://gencat-presupuestos.gobify.net but they won't require significant changes to this PR.

Production won't be affected if we merge this because its deploy has not been modified yet to replace the layout files, so even if the pipeline is working, the files won't replace the current ones.

@amiedes amiedes requested a review from ferblape October 19, 2018 12:17
@amiedes
Copy link
Contributor Author

amiedes commented Oct 19, 2018

@ferblape please don't review this yet. After what we've discussed in other issues I want to review some of the changes I've made here to the layout for making it more resilient.

@ferblape ferblape merged commit 4df0ed0 into master Oct 22, 2018
@ferblape ferblape deleted the 325-import-layout branch October 22, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants