User management within the the Admin namespace #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here are the processes covered here: - Registration - Session management - Confirmation - Password reset
- Also increases test coverage.
- List users. - Edit user. - Edit user password. - Resend welcome email. - Resend confirmation instructions, when applicable. - Normalize implementations between namespaces. - Increase test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #32.
Before reviewing
This PR strongly depends on #53, so let's get it fully merged before checking this out.
What does this PR do?
This PR pretends to implement all User management features through the Admin UI.
Those features are:
Regarding technical stuff, both Admin and User implementations have been normalized in terms of code and architecture. The test coverage in both namespaces has been increased as well.
How should this be manually tested?
This PR is pretty large as well, so let's split it into smaller entry points:
List Users
Starting from http://gobierto.dev/admin/users, just check that data are displayed correctly, and every single row links to the corresponding Edit and Show actions.
Edit User
From the Edit view (
http://gobierto.dev/admin/users/<user_id>/edit), check that onlynameandemailfields are editable, and there are links for changing password and resending the welcome email.Resend confirmation instructions
Being in the same view (
http://gobierto.dev/admin/users/<user_id>/edit), the welcome email should be delivered by hitting the "Resend welcome email" button.Change User password
Right in
http://gobierto.dev/admin/users/<user_id>/passwords/new(also reachable from the Edit view), check the user password is actually changed.Admin management normalization
The UI between Admin and User management has been normalized as well. Check it out at http://gobierto.dev/admin/admins.