Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Integration: Formidable Forms #750

Closed
danieliser opened this issue Feb 13, 2020 · 2 comments · Fixed by #872
Closed

Form Integration: Formidable Forms #750

danieliser opened this issue Feb 13, 2020 · 2 comments · Fixed by #872

Comments

@danieliser
Copy link
Member

danieliser commented Feb 13, 2020

Plugin: https://formidableforms.com/

@fpcorso fpcorso added this to the v1.12 milestone Jun 5, 2020
@fpcorso fpcorso changed the title Form Integration: Formiddable Forms Form Integration: Formidable Forms Aug 6, 2020
@fpcorso fpcorso added this to To Do in Form plugin integration system via automation Aug 19, 2020
fpcorso added a commit that referenced this issue Aug 20, 2020
@fpcorso
Copy link
Contributor

fpcorso commented Aug 20, 2020

@danieliser Making progress on this one:
formidable-forms-example

But, can you point me to where the pum_form_popup_id is set? It shows in the CF7's on_success method but isn't set in the CF7's JS file: https://github.com/PopupMaker/Popup-Maker/blob/feature/750/classes/Integration/Form/ContactForm7.php#L94

Is that done automatically somewhere that I don't have to worry about?

fpcorso added a commit that referenced this issue Aug 20, 2020
fpcorso added a commit that referenced this issue Aug 20, 2020
fpcorso added a commit that referenced this issue Aug 20, 2020
fpcorso added a commit that referenced this issue Aug 20, 2020
@fpcorso fpcorso linked a pull request Aug 20, 2020 that will close this issue
9 tasks
@danieliser
Copy link
Member Author

@fpcorso This should handle it:

var $popup = PUM.getPopup(this),
popupID = PUM.getSetting($popup, 'id'),
$forms = $popup.find('form');
/**
* If there are forms in the popup add a hidden field for use in retriggering the popup on reload.
*/
if ($forms.length) {
$forms.append('<input type="hidden" name="pum_form_popup_id" value="' + popupID + '" />');
}

fpcorso added a commit that referenced this issue Sep 8, 2020
@fpcorso fpcorso closed this as completed Sep 17, 2020
Form plugin integration system automation moved this from To Do to Done Sep 17, 2020
@fpcorso fpcorso mentioned this issue Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants