Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NFData and Binary instances to EmailAddress #25

Closed
3noch opened this issue Sep 16, 2017 · 2 comments
Closed

Add NFData and Binary instances to EmailAddress #25

3noch opened this issue Sep 16, 2017 · 2 comments
Assignees
@Porges
Milestone
v3.0

Comments

@3noch
Copy link

3noch commented Sep 16, 2017

Since you're just wrapping ByteString you might as well offer the same instances. These also come in hand for serialization.
@Porges Porges added this to the v2.3.3 milestone Nov 6, 2017
@Porges
Copy link
Owner

Porges commented Nov 6, 2017

This seems reasonable and easy 🙂 👍

@Porges Porges self-assigned this Nov 6, 2017
@Porges Porges mentioned this issue Jun 26, 2018
Open
24 tasks
Porges added a commit that referenced this issue Jun 27, 2018
@Porges
Add Binary instance
54bdbbd 
This fixes #25.
Porges added a commit that referenced this issue Jun 27, 2018
@Porges
Add Binary instance
671f589 
This fixes #25.
@Porges Porges modified the milestones: v2.3.3, v3.0 Jun 27, 2018
@Porges
Copy link
Owner

Porges commented Jun 27, 2018

Doing this as part of the v3.0 changes, since I've picked this up again to finish it.

@Porges Porges closed this as completed Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Porges Porges

Labels
None yet
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
2 participants
@Porges @3noch