Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FL-151L Fuel tank adapter, Incorrect variants. #641

Closed
omega489 opened this issue Jul 5, 2019 · 3 comments
Closed

FL-151L Fuel tank adapter, Incorrect variants. #641

omega489 opened this issue Jul 5, 2019 · 3 comments
Assignees
Labels
bug bug pertains to non-art issues making history content related to making history

Comments

@omega489
Copy link

omega489 commented Jul 5, 2019

Branch:

Develop, Making History

Issue:

FL-151L Fuel tank adapter (Adapter - 1.875 to 1.25m Long) from the making history parts has a variants issue. Multiple variants z-fight in all variants of the part.

Cause:

In cfg file "restock-mh-fueltanks-1875.cfg" there are some incorrect mesh names and one instance of two meshes enabled by mistake. Lines 403-450.

MODULE
{
name = ModulePartVariants
useMultipleDragCubes = false
baseVariant = White
VARIANT
{
name = White
displayName = #autoLOC_8007122
themeName = BlackAndWhite
primaryColor = #ffffff
secondaryColor = #000000
GAMEOBJECTS
{
1875-125Long = true
1875-125GreyLong = false
1875-125OrangeLong = true
}
}
VARIANT
{
name = Grey
displayName = #autoLOC_8007119
themeName = White
primaryColor = #ffffff
secondaryColor = #ffffff
GAMEOBJECTS
{
1875-125Long = false
1875-125GreyLong = true
1875-125OrangeLong = false
}
}
VARIANT
{
name = Dark Grey
displayName = #autoLOC_8007121
themeName = GrayAndOrange
primaryColor = #4c4f47
secondaryColor = #f49841
GAMEOBJECTS
{
1875-125Long = false
1875-125GreyLong = false
1875-125OrangeLong = true
}
}
}

Fix:

Changes the mesh names from "GreyLong" to "LongGrey" etc. for all offending meshes.

MODULE
{
name = ModulePartVariants
useMultipleDragCubes = false
baseVariant = White
VARIANT
{
name = White
displayName = #autoLOC_8007122
themeName = BlackAndWhite
primaryColor = #ffffff
secondaryColor = #000000
GAMEOBJECTS
{
1875-125Long = true
1875-125LongGrey = false
1875-125LongOrange = false
}
}
VARIANT
{
name = Grey
displayName = #autoLOC_8007119
themeName = White
primaryColor = #ffffff
secondaryColor = #ffffff
GAMEOBJECTS
{
1875-125Long = false
1875-125LongGrey = true
1875-125LongOrange = false
}
}
VARIANT
{
name = Dark Grey
displayName = #autoLOC_8007121
themeName = GrayAndOrange
primaryColor = #4c4f47
secondaryColor = #f49841
GAMEOBJECTS
{
1875-125Long = false
1875-125LongGrey = false
1875-125LongOrange = true
}
}
}

@ChrisAdderley ChrisAdderley self-assigned this Jul 5, 2019
@ChrisAdderley ChrisAdderley added the bug bug pertains to non-art issues label Jul 5, 2019
@ChrisAdderley ChrisAdderley added this to To do in Restock v1.0.0 Release via automation Jul 5, 2019
@ChrisAdderley ChrisAdderley moved this from To do to Ready for Review in Restock v1.0.0 Release Jul 5, 2019
ChrisAdderley added a commit that referenced this issue Jul 5, 2019
@ChrisAdderley
Copy link
Contributor

Fixed in develop, good find, unfortunately I don't have MH so have trouble testing the patched versions.

@ChrisAdderley ChrisAdderley added the making history content related to making history label Jul 8, 2019
@ChrisAdderley
Copy link
Contributor

Let me know if this is confirmed resolved.

@omega489
Copy link
Author

I can confirm it is resolved.

Restock v1.0.0 Release automation moved this from Ready for Review to Done Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug pertains to non-art issues making history content related to making history
Projects
No open projects
Development

No branches or pull requests

2 participants