Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New RCS plumes #76

Closed
TykoTek opened this issue Dec 20, 2018 · 14 comments
Closed

New RCS plumes #76

TykoTek opened this issue Dec 20, 2018 · 14 comments
Assignees
Labels
enhancement fx issue relates to part fx restock base content is base restock
Milestone

Comments

@TykoTek
Copy link

TykoTek commented Dec 20, 2018

The RCS exhaust plumes on the quad RCS look like they're starting too far inside the nozzle so some of the plume is "leaking" through the nozzle sides

screenshot8

It's less noticeable on the linear RCS port

screenshot9

@ChrisAdderley
Copy link
Contributor

I am working on a new, better RCS effect which will resolve this problem - I've edited the title to reflect this.

@ChrisAdderley ChrisAdderley self-assigned this Dec 20, 2018
@ChrisAdderley ChrisAdderley added enhancement restock base content is base restock labels Dec 20, 2018
@ChrisAdderley ChrisAdderley changed the title RCS plume New RCS plumes Dec 20, 2018
@ChrisAdderley ChrisAdderley added the fx issue relates to part fx label Jan 2, 2019
@Vladimir-csp
Copy link
Contributor

Cool!
May I suggest linking thrust to the opacity of particles, not quantity or speed or lifetime? At least in vacuum.

@ChrisAdderley ChrisAdderley added this to the 0.1.0 (initial release) milestone Jan 2, 2019
@ChrisAdderley
Copy link
Contributor

I don't believe that is possible with stock.

@ChrisAdderley
Copy link
Contributor

Added with 08c1ca1

@TykoTek
Copy link
Author

TykoTek commented Jan 23, 2019

@ChrisAdderley 4 way RCS only has audio when thrusting in 1 direction. The other 3 directions are silent

@ChrisAdderley
Copy link
Contributor

75f8b41 should fix that. Today I learned that there's a whole different category of FX configuration for sound for RCS!

@TykoTek
Copy link
Author

TykoTek commented Jan 24, 2019

All four directions have sound now, but one of the directions sounds different. I'm pretty sure it was the only direction that had sound before. It sounds higher pitched than the other three directions

@Poodmund
Copy link
Collaborator

Poodmund commented Jan 24, 2019

Didn't realise this discussion was already happening, anyway, here's a video of it occuring for reference: https://www.youtube.com/watch?v=_5Bo3wyYMuA

To clarify, 75f8b41 has rectified the issue of sound not triggering in all directions but as Tyko has pointed out above, the forward thrust (H) sound is stronger and higher pitched and the backwards thrust (N) is lower pitched than the other movements.

@ChrisAdderley
Copy link
Contributor

Still don't know what is going on, tried some things with the recent merge, don't know if it did anything.

@TykoTek
Copy link
Author

TykoTek commented Jan 30, 2019

Sounds are still inconsistent. In the current build the plumes are missing from 3 directions and the 4th only has a tiny plume. The nozzle with the tiny plume is not nozzle with a different sound. So there are two issues at work here.

https://youtu.be/y7tkC3C-20s

@ChrisAdderley
Copy link
Contributor

Ok let's try again for #229. And if the sound is not right I have no goddamn clue and am closing the issue anyways

@TykoTek
Copy link
Author

TykoTek commented Jan 30, 2019

There are still sounds issues, with one nozzle sounding higher pitched than the rest. That issue has been copied to the rest of the RCS blocks. It's not always the nozzle pointing down though.

Also, some plume issues on the smaller blocks mostly with the plume emanating off-center from the nozzle and/or at a different angle than the nozzle is pointing

I've built a test platform. On it each RCS block is tied to an action group, 1-10 and they're all off by default, so you can activate each one individually.

https://www.dropbox.com/s/19fntxah2f2ku9b/RCS%20test.craft?dl=0

@ChrisAdderley
Copy link
Contributor

Sound fix as per Ensou at 95d10f4 (untested)

@TykoTek
Copy link
Author

TykoTek commented Jan 31, 2019

Tested and confirmed :)

@TykoTek TykoTek closed this as completed Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement fx issue relates to part fx restock base content is base restock
Projects
None yet
Development

No branches or pull requests

4 participants