wasapi: Improvement to lower possible cases of underruns due to coarse system timer and time-hungry user-side processing.. #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmitrykos to remove the unwanted merge commits, you should be able to rebase your branch off master and force update, something like: https://www.digitalocean.com/community/tutorials/how-to-rebase-and-update-a-pull-request Please don't merge untidy commit history to master. Use squash and/or rebase GitHub merge options. |
|
@RossBencina thank you very much for the tutorial on rebasing, managed to cleanup that mess successfully :) |
dmitrykos
changed the title
|
@dmitrykos I confirm that aecafb1 is an effective fix to #303 on my system in shared mode. My system has 1056 samples as the lowest host buffer size. I have tested user buffer size of 2112, 1056, 528, 264, 132, 66, 1024 on multiple devices (built-in audio, HDMI and USB), each 5 times each and I have no glitching. |
…ow host latency requsted (22 ms): - Implement workaround for system timer coarse granularity causing underruns by using timeBeginPeriod/timeEndPeriod APIs inside the Event and Poll thread handlers. - Update next sleep time of the Poll rendering loop dynamically depending on time taken for processing/rendering of audio data into the available host buffer to avoid underruns and fit processing time into periodic polling time slots. - Add support for time slots logging in Poll mode if PA_WASAPI_LOG_TIME_SLOTS is defined. Fixed audible glitches by preloading the whole host buffer before stream is started. - Fix audible glitches on stream start by preloading the whole host buffer before stream is started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To combat underruns there were several changes implemented:
Implemented workaround for system timer coarse granularity causing underruns by using timeBeginPeriod/timeEndPeriod APIs inside the Event and Poll thread handlers. Coarse system timer breaks precision of waiting for a next time slot causing underruns as a result.
Updated next sleep time of the Poll rendering loop dynamically depending on time taken for processing/rendering of audio data into the available host buffer to avoid underruns and fit processing time into periodic polling time slots. It will minimize possibility of the underruns if user buffer is 1/2 of the host buffer and user code takes less than 1/2 of the host buffer duration.