wasapi: Fixed glitchy audio in case of Exclusive mode and 24-bit packed format. #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…format and USB DAC (other audio devices using the same audio format could be affected too).
dmitrykos
added
src-wasapi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed glitchy audio in case of Exclusive mode, Polling mode, 24-bit packed format and USB DAC as output device. Other audio devices using the same combination could be affected too.
The reason of glitches is periodic underrun which can only be fixed by using paUtilFixedHostBufferSize mode which is trying to fill the available host buffer more rapidly. As a bonus paUtilFixedHostBufferSize results in less CPU usage as it will consume the whole user buffer per pass.