Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't link to macOS frameworks with an absolute path #56

Closed
daschuer opened this issue Jul 27, 2023 · 2 comments · Fixed by #57
Closed

Don't link to macOS frameworks with an absolute path #56

daschuer opened this issue Jul 27, 2023 · 2 comments · Fixed by #57

Comments

@daschuer
Copy link
Contributor

daschuer commented Jul 27, 2023

portmidi suffers from microsoft/vcpkg#16259

See portmidi/PortMidiTargets.cmake

set_target_properties(PortMidi::portmidi PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include;${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "\$<LINK_ONLY:Threads::Threads>;/Applications/Xcode_12.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/CoreAudio.framework;/Applications/Xcode_12.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/CoreFoundation.framework;/Applications/Xcode_12.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/CoreMIDI.framework;/Applications/Xcode_12.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/CoreServices.framework"
)

This should use "-Wl,-framework,CoreServices" instead.

daschuer added a commit to daschuer/portmidi that referenced this issue Jul 27, 2023
@rbdannenberg
Copy link
Contributor

I'm not a big advocate of installer and package configuration features of CMake. I see the advantages if all libraries and subsystems use CMake consistently, but it's also complex, fragile, and not very stable. I'm happy to include this stuff in Portmidi to the extent others find it useful, but I don't support it, and my recommendation is simply add Portmidi files (a small library) to your project if you need it, or just build a static Portmidi library and link to it. If there's a tested code fix you'd like me to incorporate, let me know.

@daschuer
Copy link
Contributor Author

Thank you. I am currently preparing a test CI run that shows the issue and tests the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants