Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pm_mac: handle eox even when multiple small messages are part of one packet #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

te-johan
Copy link

during a midi stress tests i noticed that sometimes sysex messages got stuck in PortMidi.
what was specific to the error cases was that there was always a real time event just before the last byte of a sysex message.
ie . [0xf0, 0x1d, 0x51, 0xf8, 0xf7]

coremidi sends one packet containing 0xf8 and 0xf7 and the old code did not handle that case correctly.

@rbdannenberg
Copy link
Contributor

Wow, this sounds significant -- great find! This stuff is tricky and amazing this hasn't come up after so many years of use, but maybe sysex is pretty unusual so this is definitely an rare case. I want to look at this carefully and have some other things to merge that I put off due to travel, but I think I can do this within a week. Your contribution, especially taking time to track down the problem, is greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants