Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cacheForceRefresh and empty headers fix #34

Merged
merged 2 commits into from
Feb 13, 2024
Merged

fix: cacheForceRefresh and empty headers fix #34

merged 2 commits into from
Feb 13, 2024

Conversation

VisargD
Copy link
Collaborator

@VisargD VisargD commented Feb 12, 2024

Title: cacheForceRefresh and empty headers fix

Description:

  • Add an isEmpty check before setting header values to avoid empty headers in request.
  • Accept cacheForceRefresh as a parm

Motivation:

  • To fix errors and support latest signature

Related Issues:

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 12, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 13, 2024
@VisargD VisargD merged commit ce29c7f into main Feb 13, 2024
1 check passed
@VisargD VisargD deleted the fix/empty-headers branch February 13, 2024 15:23
@VisargD VisargD mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrushankportkey vrushankportkey vrushankportkey approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle empty values in createHeaders Accept cacheForceRefresh as setting and pass it as header
2 participants
@VisargD @vrushankportkey