Feat/wrapper #40
Feat/wrapper #40
Conversation
dosubot
bot
added
the
size:XXL
tests/images/openai.test.ts
Outdated
| }, 120000); | ||
|
|
||
|
|
||
| // test('model: gpt-4-1106-preview', async () => { |
There was a problem hiding this comment.
Please remove comments if they are not required. From other files as well.
|
|
||
| config({ override: true }) | ||
| const client = new Portkey({ | ||
| apiKey: process.env["PORTKEY_API_KEY"] ?? "", |
There was a problem hiding this comment.
Please remove the DEV base url. We can use the default PROD url for testing SDKs.
…ged, BASE URL changed
src/apis/images.ts
Outdated
|
|
||
| export interface ImagesBody { | ||
| prompt: string; | ||
| model?: (string & {}) | "dall-e-2" | "dall-e-3"; |
There was a problem hiding this comment.
Can we change this to just a normal string type?
src/apis/images.ts
Outdated
| n?: number | null; | ||
| quality?: "standard" | "hd"; | ||
| response_format?: "url" | "b64_json" | null; | ||
| size?: "256x256" | "512x512" | "1024x1024" | "1792x1024" | "1024x1792" | null; |
There was a problem hiding this comment.
Are these required or can we just make it a string?
src/apis/images.ts
Outdated
| quality?: "standard" | "hd"; | ||
| response_format?: "url" | "b64_json" | null; | ||
| size?: "256x256" | "512x512" | "1024x1024" | "1792x1024" | "1024x1792" | null; | ||
| style?: "vivid" | "natural" | null; |
There was a problem hiding this comment.
This can also just be a string as other providers might have different styles
|
@csgulati09 - We should try to make our interfaces as flexible as possible because Portkey SDK will be used for providers other than openai as well. Have added a few comments related to this. But the broader idea is to keep things open-ended for input params so that if the values are different for other providers, it does not break for them |
src/apis/threads.ts
Outdated
| metadata?: unknown | null; | ||
| } | ||
|
|
||
| export namespace ThreadCreateParams { |
|
Closes #38 |
Title: Revamp: wrapper around OpenAI SDK (Hybrid)
Description:
Motivation:
This will make it easier for us to integrate newly introduced routes from OpenAI
Related Issues:
#38