Feat/render #45
Merged
Feat/render #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
dosubot
bot
added
size:S
VisargD
reviewed
Mar 22, 2024
src/apis/generations.ts
Outdated
| @@ -47,6 +47,20 @@ type PromptsResponse = Record<string, any> & APIResponseType; | |||
|
|
|||
| export class Prompt extends ApiResource { | |||
| completions: PromptCompletions = new PromptCompletions(this.client); | |||
|
|
|||
| render( | |||
| _body: PromptsCreateNonStreaming, | |||
There was a problem hiding this comment.
Should we use PromptBodyBase instead of PromptsCreateNonStreaming? Using the current one will give errors if someone sends anything apart from promptID and variables.
There was a problem hiding this comment.
PromptsCreateNonStreaming extends PromptBodyBase which extends ModelParams
So it will be able to cover everything, I suppose
VisargD
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: prompt/render
Description:
Motivation:
Enable the users to use the /render endpoint
Related Issues:
#44