Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/metadata #130

Merged
merged 3 commits into from
May 31, 2024
Merged

Hotfix/metadata #130

merged 3 commits into from
May 31, 2024

Conversation

csgulati09
Copy link
Collaborator

Title: Type of meta data in the with_options

Description:

  • The mentioned type was optional str.
  • Needed type should have been optional dict[str, str]
  • Final changes made include both, this is to ensure there are no breaking changes

Motivation:
Issue reported by a user

Related Issues:
#128

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 14, 2024
@csgulati09 csgulati09 self-assigned this May 14, 2024
@dosubot dosubot bot added the lgtm label May 14, 2024
@VisargD VisargD merged commit 4f84fe4 into main May 31, 2024
2 of 5 checks passed
@VisargD VisargD deleted the hotfix/metadata branch May 31, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants