Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing to gitversion 4, and mode mainline #56

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

gaelcolas
Copy link
Contributor

I think the Mainline mode would work well for Trunk based dev as you do.
I think we should:

  • build and pre-release every PR that you merge to master as a preview
  • release main versions when upon tag

This simple PR is a way to open the discussion.
There's also a dotnet core task of GitVersion 4 that might have a different name, and we should probably use instead.

@Jaykul
Copy link
Member

Jaykul commented Feb 22, 2019

Yep, I'm switching to 4 and mainline on all my projects, thanks.
You took the "beta" tag off for feature branches though.
What tag does it apply by default, branch name? I guess it's fine, regardless...

@Jaykul Jaykul merged commit 792b2fd into PoshCode:master Feb 22, 2019
@gaelcolas gaelcolas deleted the feature/gitversion branch February 23, 2019 06:40
@gaelcolas
Copy link
Contributor Author

Yes it's branch name + commit increment.
I think using Beta is misleading as it's only isolated feature branch, and knowing its actual history is tricky.
The commits of -beta0004 would not necessary be in -beta0008, if they're from two different feature branches, and none of them merged yet.
I might be wrong though, but it seems confusing nonetheless! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants