Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next stable version of Luma3DS will change path and break this #9

Closed
CouldBeWolf opened this issue Nov 25, 2016 · 11 comments
Closed

Next stable version of Luma3DS will change path and break this #9

CouldBeWolf opened this issue Nov 25, 2016 · 11 comments
Assignees
Milestone

Comments

@CouldBeWolf
Copy link

CouldBeWolf commented Nov 25, 2016

This commit to Luma3DS changes paths and naming.

"changed structure for game patches: language emulation txts now go to /luma/titles/<titleid>/locale.txt, code.bins go to /luma/titles/<titleid>/code.bin, RomFSes go to /luma/titles/<titleid>/romfs"

@simonrule
Copy link

yes i just got answer from AuroraWright and she said that lumalocalswitcher need to be updated
here what she did say
"The issue isn't in Luma, it's in that "locale switcher" app which needs to be updated for the new folder layout in nightlies (/luma/titles/titleID/locale.txt instead of /luma/locales/titleID.txt)."

@CouldBeWolf
Copy link
Author

If you bothered clicking the link it's already explained there, so no need to bother AuroaWright. I now see the formating broke my copy paste4, but I fixed it. But really, it was clearly explained.

@simonrule
Copy link

thank you so much :)

@Possum Possum self-assigned this Dec 21, 2016
@Possum Possum added this to the 0.03 milestone Dec 21, 2016
@Possum
Copy link
Owner

Possum commented Dec 21, 2016

@ericjwg if you don't mind, can you get me a patch with the change(s) in your build? Or better yet, submit a pull request (so git history reflects the proper attribution).

@gingerbeardman
Copy link

gingerbeardman commented Mar 6, 2017

This just caught me out: LumaTeam/Luma3DS#350 (comment)

Any chance of the fix being merged?

@Margen67
Copy link

Margen67 commented Mar 6, 2017

@Possum #10

@Margen67
Copy link

Margen67 commented Mar 6, 2017

@gingerbeardman Most likely not. @Possum and this repo hasn't had any activity since 2016 so I presume this repository is dead.

@Possum
Copy link
Owner

Possum commented Mar 8, 2017

Astute observation.

Indeed, I've been quite lazy busy lately and haven't had time to come up with a way to implement this maintaining backwards compatibility (though at this point, that's probably not a necessary goal).

I pushed some code changes I've been sitting on that might do the trick. I haven't been able to get a build to run on my 3DS (likely toolchain issues on my end - everything I try to build is black screen), but it might build for others. Totally untested, so probably a good idea to keep a backup of your SD card if you run this just in case.

Once I figure out what's going on with my toolchain I'll try to upload a working build.

@Possum
Copy link
Owner

Possum commented Mar 10, 2017

Ok, more changes in master. It should compile and run now with the latest libctru.

There had been some substantial changes in the graphics libraries since I last touched the code so that's why I was getting weird results. I lifted the necessary changes from FBI's code base and now it runs. I also made some improvements and I think it's working acceptably with some basic testing. I'll release a CIA in the next couple of days.

Thanks for your patience :)

@Possum Possum mentioned this issue Mar 10, 2017
@Margen67
Copy link

Margen67 commented Mar 17, 2017

@Possum This needs to be addressed. People make invalid issues on the Luma3DS repo almost once a day because LumaLocaleSwitcher uses outdated paths meant for 6.6 Stable Luma3DS.
There's a working build here but most people will just get the latest release (0.02)

https://github.com/AuroraWright/Luma3DS/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20region

https://github.com/AuroraWright/Luma3DS/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20patching

@Possum
Copy link
Owner

Possum commented Apr 6, 2017

New builds are up.

I created two builds because I did not want to confuse users who are using the latest stable version of Luma3DS. It should just work™ for users running a stock setup. Users running Luma NIGHTLY have the option to change it, or download the "NIGHTLY" build for the defaults there.

FWIW I don't run Luma NIGHTLY on my primary system.

PS - I looked over those bugs in the Luma repository, and they did not seem to indicate any issues stemming from using this tool, and there were only a handful of reporters confused about the path change.

@Possum Possum closed this as completed Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants