Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating numerical properties via the UI changes type to string #3189

Closed
2 tasks
yakkomajuri opened this issue Feb 4, 2021 · 0 comments · Fixed by #3202
Closed
2 tasks

Updating numerical properties via the UI changes type to string #3189

yakkomajuri opened this issue Feb 4, 2021 · 0 comments · Fixed by #3202
Labels
bug Something isn't working right

Comments

@yakkomajuri
Copy link
Collaborator

Bug description

Please describe.
If this affects the front-end, screenshots would be of great help.

When updating the numerical properties of a user on the PostHog UI, they become strings once saved.

Expected behavior

If the prop was a number, we should try to convert it to a number upon change, if that fails, we can default to string.

How to reproduce

  1. Go to a person page
  2. Update a numerical prop
  3. Watch it become a string

Environment

  • PostHog Cloud
  • self-hosted PostHog, version/commit: please provide

Additional context

Thank you for your bug report – we love squashing them!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix numerical person properties turning to strings on save PostHog/posthog
1 participant
@yakkomajuri