Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events and Persons page stacks when selected #4483

Closed
2 tasks
DimitrisMazarakis opened this issue May 25, 2021 · 5 comments
Closed
2 tasks

Events and Persons page stacks when selected #4483

DimitrisMazarakis opened this issue May 25, 2021 · 5 comments
Labels
bug Something isn't working right P2 Semi-urgent, non-breaking, affects UX but functional

Comments

@DimitrisMazarakis
Copy link
Contributor

DimitrisMazarakis commented May 25, 2021

Bug description

When I select Events or Persons page it's like it stacks and I cannot select another page for 2-5 seconds. I think this happens because it has to load some data to these pages but if you accidentally navigate to events or persons page then you are doomed to stay there until it unstacks. And also the hotkey popup does not disappear while it is stacked.

Screenshot from 2021-05-25 21-55-42

Screenshot from 2021-05-25 21-55-11

Expected behavior

When you navigate to Events or Persons page you can instantly change to another page without menu lagging.

How to reproduce

  1. Go to events or Persons page from menu or with hotkey (G + E)
  2. Then try to click another page through the menu

Environment

  • PostHog Cloud
  • self-hosted PostHog, version/commit: 1.25.0
@DimitrisMazarakis DimitrisMazarakis added the bug Something isn't working right label May 25, 2021
@fuziontech
Copy link
Member

fuziontech commented May 25, 2021

I can't seem to reproduce it on OSX w/ Chrome. @DimitrisMazarakis - what browser & OS are you on?

@fuziontech
Copy link
Member

Was able to reproduce on OSX w/ Safari. Definitely more pronounced on the Persons tab, but also happens with the Events tab as well. Will block dock selection until the page is loaded it seems.

@DimitrisMazarakis
Copy link
Contributor Author

@fuziontech I use firefox for browser and ubuntu for OS

@mariusandra
Copy link
Collaborator

Extra context:

This has to do with large antd tables rendering really really slow. @alexkim205 has been working on improving this and it seems that the true solution is to move to react-table or similar virtualized table library.

Related:

With 6x CPU throttling enabled, it took ~6 seconds to just render the DOM nodes making up the initial table:

image

That plus diffing, slight layout adjustments, etc leads to a really degraded experience for basically anyone not on a M1 chip.

@alexkim205 alexkim205 added the P2 Semi-urgent, non-breaking, affects UX but functional label Sep 15, 2021
@alexkim205 alexkim205 removed their assignment Sep 15, 2021
@paolodamico
Copy link
Contributor

Fixed either by turbo mode or the new UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right P2 Semi-urgent, non-breaking, affects UX but functional
Projects
None yet
Development

No branches or pull requests

6 participants