Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use breadcrumbs logic for tab title #7214

Closed
Twixes opened this issue Nov 18, 2021 · 1 comment
Closed

Use breadcrumbs logic for tab title #7214

Twixes opened this issue Nov 18, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@Twixes
Copy link
Collaborator

Twixes commented Nov 18, 2021

Is your feature request related to a problem?

Currently we have setPageTitle()s sprinkled around the codebase, which provides users with meaningful PostHog tab titles in the browser tab. However, this way there are many sources of truth for the title and they aren't entirely accurate. For instance, the Insights page is titled "Saved insights", while a feature flag's page just says "Feature flag" when it would be very helpful to show the feature flag's actual key.

Describe the solution you'd like

This exact challange was part of the implementation of breadcrumbs and now it's (mostly) solved by breadcrumbsLogic.
Since the tab title is basically abbreviated breadcrumbs, we should just consolidate all the setPageTitle()s into a single callsite in breadcrumbsLogic for a single and accurate source of truth.

Thank you for your feature request – we love each and every one!

@Twixes
Copy link
Collaborator Author

Twixes commented Oct 21, 2022

This is implemented now.

@Twixes Twixes closed this as completed Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants