fix: about component descritions issues

Postcatlab · Jun 28, 2022 · a21e1c1 · a21e1c1
1 parent 1b86fab
commit a21e1c1
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/src/workbench/browser/src/app/shared/components/setting/common/about.component.ts b/src/workbench/browser/src/app/shared/components/setting/common/about.component.ts
@@ -9,6 +9,8 @@ type DescriptionsItem = {
   value: string;
 };
 
+const isElectron = !!(window && window.process && window.process.type);
+
 const descriptions: DescriptionsItem[] = [
   {
     id: 'version',
@@ -54,6 +56,10 @@ const electronDetails: DescriptionsItem[] = [
     value: '',
   },
 ];
+
+if (isElectron) {
+  descriptions.push(...electronDetails);
+}
 @Component({
   selector: 'eo-about',
   template: `
@@ -85,7 +91,6 @@ export class AboutComponent implements OnInit {
   constructor(private electron: ElectronService) {}
 
   ngOnInit(): void {
-    this.appendDetailWithElectron();
     // fetch('https://api.github.com/repos/eolinker/eoapi/releases')
     //   .then((response) => response.json())
     //   .then((data) => {
@@ -116,15 +121,6 @@ export class AboutComponent implements OnInit {
     });
   }
 
-  appendDetailWithElectron() {
-    if (!this.electron.isElectron) {
-      return;
-    }
-
-    // this.list = [...this.list, ...electronDetails];
-    this.list.push(...electronDetails);
-  }
-
   getSystemInfo() {
     const systemInfo = this.electron.ipcRenderer.sendSync('get-system-info');
     return systemInfo;