die on "fe_sendauth: no password supplied"

[steve-chavez]

Problem

We keep retrying the connection when we get a fe_sendauth: no password supplied.

Reported on gitter.

Solution

Die when the above error happens. Should be done here:

postgrest/src/PostgREST/Error.hs

Lines 449 to 454 in 54cbf14

	checkIsFatal :: SQL.UsageError -> Maybe Text
	checkIsFatal (SQL.ConnectionUsageError e)
	| isAuthFailureMessage = Just $ toS failureMessage
	| otherwise = Nothing
	where isAuthFailureMessage = "FATAL: password authentication failed" `isInfixOf` failureMessage
	failureMessage = BS.unpack $ fromMaybe mempty e

[steve-chavez]

If you have a local database(besides the nix one), this can be reproduced with:

PGHOST="localhost" postgrest-run

06/Jun/2023:14:19:49 -0500: Attempting to connect to the database...
06/Jun/2023:14:19:49 -0500: {"code":"PGRST000","details":"connection to server at \"localhost\" (::1), port 5432 failed: fe_sendauth: no password supplied\n","hint":null,"message":"Database co
nnection error. Retrying the connection."}
06/Jun/2023:14:19:49 -0500: connection to server at "localhost" (::1), port 5432 failed: fe_sendauth: no password supplied