Simplify Nix CI jobs #1618
Merged
Simplify Nix CI jobs #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
monacoremo
commented
Oct 14, 2020
monacoremo
commented
- Removed CircleCI caching for Nix build jobs. It's finicky (e.g. Drop support for postgres 9.4 #1617 (comment)) and is not really worth it build time wise - Nix will always provide all dependencies and we only ever build PostgREST and the test suite with cabal-install, which is relatively quick
- Merged nix-build and nix-test - separating those steps makes things more complicated than they need to be and negatively impacts performance for PRs, as we can't push to cachix for those
wolfgangwalther
added a commit
to wolfgangwalther/postgrest
that referenced
this pull request
Oct 14, 2020
wolfgangwalther
added a commit
to wolfgangwalther/postgrest
that referenced
this pull request
Oct 14, 2020
|
I confirmed that this fixes #1617 (comment). When I merged this PR into both #1603 and #1617 and they were building at the same time, both were passing. When I removed those commits again, again building both at the same time, #1617 is now failing again with the error, where the test actually belongs to #1603. LGTM! |
|
Oh. This was a tricky one. Great work guys! Merging.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.