Detect db schema changes #479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awaiting ability to LISTEN with hasql to avoid the polling
Thanks hlint
|
Actually it seems like the polling loop never runs more than once... |
|
I created another PR for this. It is simpler in that it uses an IORef rather than an MVar. Also it waits for an explicit signal to reload the schema. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the correct approach to detecting schema changes is outlined in #475, I moved ahead on this PR to figure out how to make the code keep a changing schema inside an
MVar. It currently polls for changes every five minutes.While we wait for support for postgresql LISTEN in hasql to arrive in the next week I wanted to put this PR out for code review.