Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCE] Index pot config updates #32

Closed
lachlanglen opened this issue Jun 7, 2024 · 0 comments · Fixed by #37
Closed

[ENHANCE] Index pot config updates #32

lachlanglen opened this issue Jun 7, 2024 · 0 comments · Fixed by #37
Labels
enhancement small enhancement / improvement from existing feature

Comments

@lachlanglen
Copy link
Contributor

Summary

Need to add indexing of any owner/admin updates to pot config, as found in README and codebase.

Simplest solution for now might be to just call get_config() on pot whenever one of these methods is called, and save the updated data in DB. Can use fastnear for this, e.g.:

requests.get(f"{settings.FASTNEAR_RPC_URL}/account/{pot_id}/view/get_config")

Motivation

[More detailed explanation of the motivation for the enhancement, including any benefits it would provide]

Description

[Detailed description of the enhancement, including how it would work and any design considerations]

Alternatives

[Discussion of any alternative solutions that were considered and why the proposed solution is preferred]

Risks

[Identification and mitigation of any potential risks associated with the enhancement]

Acceptance Criteria

[List of criteria that must be met for the enhancement to be considered accepted]

Additional Information

[Any other relevant information, such as links to related issues or pull requests]

@lachlanglen lachlanglen added the enhancement small enhancement / improvement from existing feature label Jun 7, 2024
@lachlanglen lachlanglen linked a pull request Jul 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement small enhancement / improvement from existing feature
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant