Add missing ConfigureAwait(false) and improve Skin ctor

PotatoMaster101 · Mar 21, 2023 · 41957dc · 41957dc
1 parent 2e6a5de
commit 41957dc
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 10 deletions.
diff --git a/src/McSkin/McSkin.csproj b/src/McSkin/McSkin.csproj
@@ -1,21 +1,23 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <AssemblyVersion>1.0.0</AssemblyVersion>
+    <AssemblyVersion>1.0.1</AssemblyVersion>
     <Authors>PotatoMaster101</Authors>
     <Copyright>Copyright (c) 2023 PotatoMaster101</Copyright>
     <Description>Small library for playing with Minecraft Skins</Description>
-    <FileVersion>1.0.0</FileVersion>
+    <FileVersion>1.0.1</FileVersion>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
-    <PackageReleaseNotes>Initial release</PackageReleaseNotes>
+    <PackageReleaseNotes>- Added missing `ConfigureAwait`
+- Added `isLegacy` to `Skin` constructor</PackageReleaseNotes>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
     <PackageTags>Minecraft</PackageTags>
     <RepositoryUrl>https://github.com/PotatoMaster101/McSkin</RepositoryUrl>
     <TargetFramework>net7.0</TargetFramework>
     <Title>McSkin</Title>
+    <Version>1.0.1</Version>
   </PropertyGroup>
 
   <PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">

diff --git a/src/McSkin/Skin.cs b/src/McSkin/Skin.cs
@@ -33,7 +33,8 @@ public class Skin : IDisposable
     /// <summary>
     /// Constructs a new instance of <see cref="Skin"/>.
     /// </summary>
-    public Skin() : this(new Image<Rgba32>(StandardWidth, StandardHeight))
+    /// <param name="isLegacy">Whether the skin is a legacy skin.</param>
+    public Skin(bool isLegacy = false) : this(new Image<Rgba32>(StandardWidth, isLegacy ? LegacyHeight : StandardHeight))
     { }
 
     /// <summary>

diff --git a/src/McSkin/SkinGrabber.cs b/src/McSkin/SkinGrabber.cs
@@ -22,7 +22,7 @@ public static class SkinGrabber
     /// <exception cref="ArgumentException">Thrown when the skin image is invalid.</exception>
     public static async Task<Skin> FromFile(string path, CancellationToken cancellationToken = default)
     {
-        return new Skin(await Image.LoadAsync(path, cancellationToken));
+        return new Skin(await Image.LoadAsync(path, cancellationToken).ConfigureAwait(false));
     }
 
     /// <summary>

diff --git a/test/McSkin.Test/SkinTest.cs b/test/McSkin.Test/SkinTest.cs
@@ -10,16 +10,18 @@ namespace McSkin.Test;
 /// </summary>
 public class SkinTest
 {
-    [Fact]
-    public void Ctor1_SetsMembers()
+    [Theory]
+    [InlineData(true)]
+    [InlineData(false)]
+    public void Ctor1_SetsMembers(bool isLegacy)
     {
         // act
-        using var skin = new Skin();
+        using var skin = new Skin(isLegacy);
 
         // assert
-        Assert.False(skin.IsLegacy);
+        Assert.Equal(isLegacy, skin.IsLegacy);
         Assert.Equal(Skin.StandardWidth, skin.SkinImage.Width);
-        Assert.Equal(Skin.StandardHeight, skin.SkinImage.Height);
+        Assert.Equal(isLegacy ? Skin.LegacyHeight : Skin.StandardHeight, skin.SkinImage.Height);
     }
 
     [Theory]