Don't call out to the poundpay api when a callback_url is specified #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any update on pulling this in? |
erb in poundpay.yml
- add charge permissions - add developer charge permission callback url
this monkey patches Active Resource to make the exception's response body available as a hash parsed from the original JSON. eventually a more general version of this patch should be applied to Active Resource directly.
…d simple marketplace app
- change payment state STAGED to CREATED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of problems with doing this, forcing an external API call in the test environment being one of them. Another issue I ran into was not being able to load the console without an active network/internet connection because ActiveSupport raises an unrescued error.
If all this is doing is registering the callback_url with the poundpay servers, this certainly isn't something that needs to be done every time an application is loaded.