Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast to specific XRM Attribute/Control interfaces for typed methods based in Dataverse attributes type #41

Merged
merged 6 commits into from
Jan 4, 2022

Conversation

glemis
Copy link
Contributor

@glemis glemis commented Jan 4, 2022

Based on discussion #38
Purpose is to map the AttributeType on IAttributeDefinition to a suitable Xrm.Attributes and Xrm.Controls Interface when generating the typings for entities.

Originally had Type Definition Maps in utils/Constants but realized that made no sense as it has no global relevance.
Moved all changes to typingsHelpers. Using a Map<string, string> to hold mapping which I saw as the most straightforward way to map a string to a string.

Using dom.create.namedTypeReference to create the typing as I am largely unfamiliar with the dts-dom library though I assume this would be the correct way of doing it. Though if not please correct but this does work to set the typings.

@power-maverick-bot
Copy link

Thanks for opening your first pull request here! One of the Avengers will look into it.
If you have not followed the Code of Conduct, then Iron Man will come looking for you.

@Power-Maverick Power-Maverick self-requested a review January 4, 2022 20:00
@Power-Maverick Power-Maverick merged commit 7bb00e5 into Power-Maverick:main Jan 4, 2022
@power-maverick-bot
Copy link

I am Groot!!
Congrats on merging your first pull request! Thanks for supporting the community. All of the Avengers are now with you.

Power-Maverick added a commit that referenced this pull request Jan 21, 2022
* Resolving #35

* Improve Smart Match (#36)

* Show all files; Match smart

* Content difference identification in smart match

* Added different confidence level on content checks

* Alpha testing details added

* Additional fixes to Smart Match

* 🐛 Implement Delete All connections

* Cast to specific XRM Attribute/Control interfaces for typed methods based in Dataverse attributes type (#41)

* Changed method to return better typing.

* Gave control same treatment as attribute.

* Moved Mapping into typing helper as no need global

* readability line len and trailing ',' standards.

* Changed let => const as not reassigned.

* Minor fixes ✔️

Co-authored-by: Eric Sutter <ericsutter@kpmg.ca>
Co-authored-by: Power-Maverick <danish.naglekar@hotmail.com>

* Docs: Add @glemis as a contributor

* Fixed issue with reserved keywords on connection name

* Update release.yml

* Resolving Bug-45 (#46)

* Resolved bug but needs one more scenario handling

* Added ability to link to a new file or re-link existing to another file

* Create stale.yml

* Docs: Add @ericregnier as a contributor (#48)

* Adding DRB inside DVDT (#49)

* Partially working changes

* Works with new changes - thanks to @GuidoPreite for providing the necessary changes

* Integrating with new changes provided by Guido and some minor bug fixes

* Working DRB inside DVDT version

* Resolving conflict with main

* Docs: Add @GuidoPreite as a contributor

* Icon changes

* UI Enhancement plus added new features (#50)

* Redesigned Tree structure and added search on entities & web resources

* Identifies currently connected connection in the Tere

* Added ability to forget connection on current workspace

* Bump follow-redirects from 1.14.1 to 1.14.7 (#51)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.1 to 1.14.7.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.14.1...v1.14.7)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 🚀 Preparing for release

Co-authored-by: glemis <esutter93@hotmail.com>
Co-authored-by: Eric Sutter <ericsutter@kpmg.ca>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants