Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added method to check/retrieve current DTCs #200

Merged
merged 25 commits into from
Dec 11, 2023

Conversation

jimwhitelaw
Copy link
Collaborator

No description provided.

@jimwhitelaw jimwhitelaw reopened this Dec 11, 2023
@jimwhitelaw
Copy link
Collaborator Author

OK, I can't figure out how to squash all these commits into one change. I think that has to be done when/if the pull request is merged. I have tested this with 2 different ELM devices, 2 different vehicles and an ELM327 emulator and it works fine, but the responses were significantly different from what was documented in the datasheet. I think it would be useful to have some additional testing by others.

@jimwhitelaw jimwhitelaw marked this pull request as ready for review December 11, 2023 20:59
@PowerBroker2
Copy link
Owner

PowerBroker2 commented Dec 11, 2023

This looks like a big update with a lot of good stuff! Could you give a brief overview of all the changes? I looked through the branch to main diff and it seems like it's mainly adding a DTC checking function(s) and an example plus some whitespace stuff.

Also, I can squash and merge from my end, so there's no prob there.

@PowerBroker2
Copy link
Owner

I'll go ahead and merge now to make it easier for others to test but I won't tag out a new version until I can get one more person (maybe me?) to test successfully.

Side note - do you have a reliable way of testing if there are no trouble codes to clear?

@PowerBroker2 PowerBroker2 merged commit b7abf58 into PowerBroker2:master Dec 11, 2023
@jimwhitelaw
Copy link
Collaborator Author

Yes, it just adds one method and an example program for using it. As for testing if there are codes to clear, this code from my example worked for me:

myELM327.monitorStatus(); // Gets the number of current DTC codes present

    if (myELM327.nb_rx_state == ELM_SUCCESS)
    {            
        // We are only interested in the third byte of the response that
        // encodes the MIL status and number of codes present
        milStatus = (myELM327.responseByte_2 & 0x80);
        numCodes = (myELM327.responseByte_2 - 0x80);

I was thinking about adding another example program just for this use case. It is sort of buried in the one for fetching the codes and that would be easier for people to find.

jimwhitelaw added a commit to jimwhitelaw/ELMduino that referenced this pull request Jan 9, 2024
PowerBroker2 added a commit that referenced this pull request Jan 9, 2024
Fix for compile error re: unsigned int #200
DerKleinePunk pushed a commit to DerKleinePunk/ELMduino that referenced this pull request Jan 26, 2024
DerKleinePunk pushed a commit to DerKleinePunk/ELMduino that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants